Skip to content

Link lalsim SWIG bindings against liblalsim

Leo P. Singer requested to merge leo-singer/lalsuite:fix-multiple-copies-of-liblalsimulation-objects into master

Description

LALSimulation was distributing two copies of most of its library object code: one copy in liblalsimulation and a second copy in the SWIG Python extension.

This was done in order to have programs link against both the lalsimulation object code and also libpython, whereas the SWIG Python extension only linked against the lalsimluation object code.

Instead, distribute only one copy of the object code, in liblalsimulation, and have the SWIG Python extension link against liblalsimulation.

To include libpython in the programs, add it to LDADD for the Makefile targets for programs. Also add libpython to the pkgconfig file so that third-party programs that link against liblalsimulation also know to link against libpython.

API Changes and Justification

Backwards Compatible Changes

  • This change does not modify any class/function/struct/type definitions in a public C header file or any Python class/function definitions
  • This change adds new classes/functions/structs/types to a public C header file or Python module

Backwards Incompatible Changes

  • This change modifies an existing class/function/struct/type definition in a public C header file or Python module
  • This change removes an existing class/function/struct/type from a public C header file or Python module

If any of the Backwards Incompatible check boxes are ticked please provide a justification why this change is necessary and why it needs to be done in a backwards incompatible way.

Review Status

Please provide details on any reviews related to this change and and the associated reviewers.

Edited by Leo P. Singer

Merge request reports