Skip to content

Fix potential failures in non-default PhenomX-Spintaylor code

Marta Colleoni requested to merge marta.colleoni/lalsuite:fix_noMB_version into master

Description

This commit fixes an issue in the non-multibanded (non-default) version of PhenomXPHM-SpinTaylor, introduced post-review in this MR. Currently, if the user passes an f_max that is below the transition frequency between inspiral and merger estimated by the model, the interpolation of the Euler angle \gamma might get truncated too early, triggering an XLAL error. The current change does not affect any default/recommended version of PhenomX, but it is required to run multibanding tests in waveform reviews.

API Changes and Justification

Backwards Compatible Changes

  • [X ] This change does not modify any class/function/struct/type definitions in a public C header file or any Python class/function definitions
  • This change adds new classes/functions/structs/types to a public C header file or Python module

Backwards Incompatible Changes

  • This change modifies an existing class/function/struct/type definition in a public C header file or Python module
  • This change removes an existing class/function/struct/type from a public C header file or Python module

If any of the Backwards Incompatible check boxes are ticked please provide a justification why this change is necessary and why it needs to be done in a backwards incompatible way.

Review Status

Please provide details on any reviews related to this change and and the associated reviewers.

Merge request reports