Skip to content

Fix high cutoff in XHM_Frequency_Sequence polarization function

Cecilio Garcia-Quiros requested to merge cecilio.garcia-quiros/lalsuite:xhm-sequence into master

Description

The frequency sequence polarization function of XHM reaches larger frequencies than the internal cutoff of the model (Mfcut=0.3) and it presents a discontinuity at that frequency. This effect can be seen in XHM_FrequencySequence.ipynb. This commit changed the previous behaviour to generate FrequencySequence only up to Mfcut, but it missed to do it for the polarization function of the higher modes (it was done for the individual modes function and 22 mode only). So the discontinuity for high frequencies is due to having the content of only higher modes and not the 22 mode. The effect of the fix can also be seen in the attached notebook.

Could you have a look @geraint.pratten ?

API Changes and Justification

Backwards Compatible Changes

  • This change does not modify any class/function/struct/type definitions in a public C header file or any Python class/function definitions
  • This change adds new classes/functions/structs/types to a public C header file or Python module

Backwards Incompatible Changes

  • This change modifies an existing class/function/struct/type definition in a public C header file or Python module
  • This change removes an existing class/function/struct/type from a public C header file or Python module

If any of the Backwards Incompatible check boxes are ticked please provide a justification why this change is necessary and why it needs to be done in a backwards incompatible way.

Review Status

Please provide details on any reviews related to this change and and the associated reviewers.

Merge request reports