Skip to content

LALinference: Refactored nrutils file

Thomas Sainrat requested to merge thomas.sainrat/lalsuite:master into master

Description

Update some older, non-idiomatic constructs within the file:

  • np.vectorize(float)(np.array(...)) becomes np.array(...,dtype=np.float64)
  • The "self-vectorizing" construct in bbh_final_spin_non_precessing_Healyetal and bbh_final_spin_precessing_HBR2016is removed; this results in a performance improvement of ~20% in the former, and two orders of magnitude for the second.
  • Minor style adjustments

These changes have been discussed at length in #738 (closed) .

API Changes and Justification

Backwards Compatible Changes

  • This change does not modify any class/function/struct/type definitions in a public C header file or any Python class/function definitions
  • This change adds new classes/functions/structs/types to a public C header file or Python module

Backwards Incompatible Changes

  • This change modifies an existing class/function/struct/type definition in a public C header file or Python module
  • This change removes an existing class/function/struct/type from a public C header file or Python module

If any of the Backwards Incompatible check boxes are ticked please provide a justification why this change is necessary and why it needs to be done in a backwards incompatible way.

Review Status

Please provide details on any reviews related to this change and and the associated reviewers.

Merge request reports