Skip to content
Snippets Groups Projects

PulsarCrossCorr_v2: fixed SWIG wrapping of function with in/out arguments

Merged John Whelan requested to merge LMXBCrossCorr/lalsuite:crosscorr_swigfix into master

Description

The function XLALModifyMultiAMCoeffsWeights() modifies one of its arguments in place, so it needs a special directive to make the SWIG wrapping work.

API Changes and Justification

Backwards Compatible Changes

  • This change does not modify any class/function/struct/type definitions in a public C header file or any Python class/function definitions
  • This change adds new classes/functions/structs/types to a public C header file or Python module

Backwards Incompatible Changes

  • This change modifies an existing class/function/struct/type definition in a public C header file or Python module
  • This change removes an existing class/function/struct/type from a public C header file or Python module

If any of the Backwards Incompatible check boxes are ticked please provide a justification why this change is necessary and why it needs to be done in a backwards incompatible way.

Review Status

The resampling CrossCorr pipeline has not been reviewed yet.

Merge request reports

Merged result pipeline #607434 passed with warnings

Merged result pipeline passed with warnings for 94d48b0f

Test coverage 28.54% (0.00%) from 1 job
Code Quality is loading
Test summary results are loading

Merged by Karl WetteKarl Wette 9 months ago (Mar 14, 2024 6:26am UTC)

Loading

Pipeline #611713 failed

Pipeline failed for da0a4ae4 on master

Test coverage 28.54% (0.00%) from 1 job

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading