Skip to content

Rename pulsar lambda parameter due to name clash

Matthew Pitkin requested to merge matthew-pitkin/lalsuite:fix_lambda into master

Description

In the PulsarParameters structure (and deprecated BinaryPulsarParameters structure) a variable called LAMBDA is currently allowed as a value to be read in from a Tempo-style .par file. The variable is defined to be an orientation angle in the pinned superfluid model of https://www.arxiv.org/abs/0909.4035. However, in .par file LAMBDA already has a meaning, which is the Galactic longitude of a pulsar. This MR does the following:

API Changes and Justification

Backwards Compatible Changes

  • This change does not modify any class/function/struct/type definitions in a public C header file or any Python class/function definitions
  • This change adds new classes/functions/structs/types to a public C header file or Python module

Backwards Incompatible Changes

  • This change modifies an existing class/function/struct/type definition in a public C header file or Python module
  • This change removes an existing class/function/struct/type from a public C header file or Python module

This is required to fix a name clash.

Review Status

cc @karl-wette @david-keitel

Merge request reports