Skip to content

Fixes to the PulsarCrossCorr_v2 pipeline

John Whelan requested to merge LMXBCrossCorr/lalsuite:check-return-values-rebased into master

Description

This is a collection of three fixes to issues with the PulsarCrossCorr_v2 pipeline used for CW searches for GW from LMXBs:

  1. Several functions were not checking their return values, causing analysis jobs to silently complete with no outputs if an error was caused by incorrect input values, as documented in https://git.ligo.org/LMXBCrossCorr/LMXBCrossCorr/-/issues/65
  2. Two obsolete and unused python scripts have been removed
  3. SWIG wrapping of two structures has been fixed

API Changes and Justification

No changes to C API, only to the SWIG wrapping of the MultiAMCoeffs and MultiSSBtimes data types, as well as some data types specific to the CrossCorr code.

Backwards Compatible Changes

  • This change does not modify any class/function/struct/type definitions in a public C header file or any Python class/function definitions
  • This change adds new classes/functions/structs/types to a public C header file or Python module

Backwards Incompatible Changes

  • This change modifies an existing class/function/struct/type definition in a public C header file or Python module
  • This change removes an existing class/function/struct/type from a public C header file or Python module

If any of the Backwards Incompatible check boxes are ticked please provide a justification why this change is necessary and why it needs to be done in a backwards incompatible way.

Review Status

Please provide details on any reviews related to this change and and the associated reviewers.

This primarily affects the resampling CrossCorr pipeline, which is still to be reviewed.

Edited by John Whelan

Merge request reports