Skip to content

Make waveforms compatible with CVFMS distribution requirements

Lorenzo Pompili requested to merge lorenzo.pompili/lalsuite:lalsuite-extra-cvmfs into master

Description

@michael.puerrer and I have developed a plan https://dcc.ligo.org/G2401063 for migrating a subset of data files which currently live in lalsuite-extra to CVMFS/OSDF with the blessing of the CBC waveform sub-group chairs (tagged below), see also https://git.ligo.org/cbc/action_items/-/issues/79

In order to be distributed data files should satisfy specific requirements, and each released version of the software that accesses each file should search for it using its full, versioned basename, and should verify that the file it opens has the corresponding value set for CANONICAL_FILE_BASENAME in its top-level attrs. This MR implements these changes (for a subset of waveform models actively being by LVK analyses).

This MR should go together with an updated version of the waveform data files, currently living on CIT in /home/lorenzo.pompili/lalsuite-extra-CVMFS-porting/new_ROM_data, to be transferred to /home/lalsimulation_data and to /cvmfs/shared.storage.igwn.org/igwn/shared/auxiliary/obs_sci/cbc/waveform/lalsimulation_data after review.

CC @vijay.varma @antoni.ramos-buades @geraint.pratten

API Changes and Justification

Backwards Compatible Changes

  • This change does not modify any class/function/struct/type definitions in a public C header file or any Python class/function definitions
  • This change adds new classes/functions/structs/types to a public C header file or Python module

Backwards Incompatible Changes

  • This change modifies an existing class/function/struct/type definition in a public C header file or Python module
  • This change removes an existing class/function/struct/type from a public C header file or Python module

If any of the Backwards Incompatible check boxes are ticked please provide a justification why this change is necessary and why it needs to be done in a backwards incompatible way.

Review Status

To be reviewed, see https://git.ligo.org/waveforms/reviews/distribution-of-waveform-data-on-cvmfs/-/wikis/home

Edited by Lorenzo Pompili

Merge request reports