Skip to content

Setting the encoding of the string to be read from HDF5 attributes

Raffi Enficiaud requested to merge raffi.enficiaud/lalsuite:fixup/htf5-attribute-read into master

Description

Attributes retrieval from HDF5 files should set properly the encoding. This PR

  • adds the encoding handling of the attribute
  • adds a test for ASCII and UTF8 encodings in the relevant unit test file, along with two example files.

Related to this: https://github.com/HDFGroup/hdf5/issues/544

API Changes and Justification

Backwards Compatible Changes

  • This change does not modify any class/function/struct/type definitions in a public C header file or any Python class/function definitions
  • This change adds new classes/functions/structs/types to a public C header file or Python module

Backwards Incompatible Changes

  • This change modifies an existing class/function/struct/type definition in a public C header file or Python module
  • This change removes an existing class/function/struct/type from a public C header file or Python module

If any of the Backwards Incompatible check boxes are ticked please provide a justification why this change is necessary and why it needs to be done in a backwards incompatible way.

Review Status

Fix on the API use of HDF5, no review.

Edited by Raffi Enficiaud

Merge request reports