Skip to content

Fixes for NRTidalv3: CI pipeline, code cleanups

Jan Steinhoff requested to merge waveforms/reviews/lalsuite:nrtidalv3-ci-fix into master

Description

The NRTidalv3 unit tests were accidentally not included in the lalsimulation/test/python/Makefile.am, hence are currently not run by the CI. This MR will fix this. This also makes some code cleanups, not affecting the waveform generation through the standard interface. Thanks to @nathan-johnson-mcdaniel for spotting this!

API Changes and Justification

Backwards Compatible Changes

  • This change does not modify any class/function/struct/type definitions in a public C header file or any Python class/function definitions
  • This change adds new classes/functions/structs/types to a public C header file or Python module

Backwards Incompatible Changes

  • This change modifies an existing class/function/struct/type definition in a public C header file or Python module
  • This change removes an existing class/function/struct/type from a public C header file or Python module

Review Status

This is not a major code change. It was reviewed by @marta.colleoni and a brief statement on this fix can be found in the code inspection page.

Edited by Jan Steinhoff

Merge request reports