Skip to content

Draft: Add optional TGR parameters to pyseobnr_model.py

Lorenzo Pompili requested to merge lorenzo.pompili/lalsuite:pseob_v5 into master

Description

This MR adds a set of optional TGR parameters to pyseobnr_model.py. These are needed to extend the pSEOB test of GR to the SEOBNRv5HM and SEOBNRv5PHM waveform models (pSEOBNRv5HM, pSEOBNRv5PHM).

API Changes and Justification

Backwards Compatible Changes

  • This change does not modify any class/function/struct/type definitions in a public C header file or any Python class/function definitions
  • This change adds new classes/functions/structs/types to a public C header file or Python module

Backwards Incompatible Changes

  • This change modifies an existing class/function/struct/type definition in a public C header file or Python module
  • This change removes an existing class/function/struct/type from a public C header file or Python module

If any of the Backwards Incompatible check boxes are ticked please provide a justification why this change is necessary and why it needs to be done in a backwards incompatible way.

Review Status

Review wiki: https://git.ligo.org/cbc-testinggr/reviews/pseobnrv5phm

Merge request reports