Skip to content

LALPulsar: add PiecewiseSearch code

Karl Wette requested to merge ANU-CGA/lalsuite:PiecewiseModel into master

Description

The PiecewiseSearch code was written by ANU Ph.D. student Ben Grace, with the aim of developing an F-statistic code with a flexible signal model capable of handling rapidly-changing long-transient signals, such as post-merger remnants. A methods paper describing the code is published in PRD, and a search paper targeting post-merger remnants in GW170817 and (for the first time) GW190425 was recently accepted for publication in PRD.

Due to the code being developed over several years, I had to squash Ben's development history (145 commits) into one commit to get the code to cleanly merge into the current master. Ben's development history is preserved in the message of the first commit. The other commits from me add a very basic test suite, remove unused code and imports, convert print() statements to Python logging, and update copyright messages.

Parts of Ben's code require SymPy, which I've added as a dependency for Conda and Debian; packages aren't yet available on RL8.

API Changes and Justification

Backwards Compatible Changes

  • This change does not modify any class/function/struct/type definitions in a public C header file or any Python class/function definitions
  • This change adds new classes/functions/structs/types to a public C header file or Python module

Backwards Incompatible Changes

  • This change modifies an existing class/function/struct/type definition in a public C header file or Python module
  • This change removes an existing class/function/struct/type from a public C header file or Python module

Review Status

n/a

Edited by Karl Wette

Merge request reports