Skip to content

use standard C99 isfinite() instead of _finite/finite methods

Marco Meyer requested to merge marco.meyer/lalsuite:fix-std-finite into master

Description

This modification is meant to use the standard definition of isfinite, defined in #include <math.h>/<cmath>, in replacement of finite defined only in some compilers. This update should make a better compatibility towards modern compilers like Clang.

API Changes and Justification

Backwards Compatible Changes

  • This change does not modify any class/function/struct/type definitions in a public C header file or any Python class/function definitions
  • This change adds new classes/functions/structs/types to a public C header file or Python module

Backwards Incompatible Changes

  • This change modifies an existing class/function/struct/type definition in a public C header file or Python module
  • This change removes an existing class/function/struct/type from a public C header file or Python module

Review Status

I noticed lalpulsar (for instance) is using the method finite from GNU compiler. AFAIK, this is no standard and an alternative is to use the standard C99 method isfinite() from #include <math.h>.

Merge request reports