Skip to content

lalpulsar/conda: add path to ephemeris files in `solar_system_ephemerides` package

Karl Wette requested to merge ANU-CGA/lalsuite:XLALFileResolvePathLong-glob into master

Description

This MR allows LALPulsar codes in Conda to easily access the extended set of ephemeris files in @matthew-pitkin 's solar_system_ephemerides package. It adds the paths to the ephemeris files in that package to the default fallback path which is hard-coded into liblalpulsar.so via the --with-fallback-data-path option to ./configure.

Note that this is an optional dependency, and does not replace the existing lalpulsar-data Conda package or the files in it, which will continue to be searched first. So LALPulsar (or indeed LALSuite users) will not need to install solar_system_ephemerides, unless they happen to need one of the extended ephemeris files it provides.

To make this work, XLALFileResolvePathLong() is extended to allow glob patterns in the fallback path set by --with-fallback-data-path. This is because solar_system_ephemerides will be installed in a Python-version-dependent directory (./python*/site-packages/solar_system_ephemerides/ephemerides, relative to the location of liblalsupport.so) which will be unknown at ./configure time.

API Changes and Justification

Backwards Compatible Changes

  • This change does not modify any class/function/struct/type definitions in a public C header file or any Python class/function definitions
  • This change adds new classes/functions/structs/types to a public C header file or Python module

Backwards Incompatible Changes

  • This change modifies an existing class/function/struct/type definition in a public C header file or Python module
  • This change removes an existing class/function/struct/type from a public C header file or Python module

Review Status

n/a

Merge request reports