Skip to content

Fix rare bug in lalpulsar_MakeSFTs when frame end time coincides with end time of SFT

Evan Goetz requested to merge evan-goetz/lalsuite:fix-seek-to-end-sft into master

Description

This MR fixes a bug where when seeking to the end of the SFT time to check that the channel being evaluated is indeed part of the frames, but somehow was hitting a time that was considered "invalid". It seems like my use of 1 nanosecond to shift the end time a little smaller was running into a problem. Changing to 1 microsecond shift successfully fixed the issue.

API Changes and Justification

Backwards Compatible Changes

  • This change does not modify any class/function/struct/type definitions in a public C header file or any Python class/function definitions
  • This change adds new classes/functions/structs/types to a public C header file or Python module

Backwards Incompatible Changes

  • This change modifies an existing class/function/struct/type definition in a public C header file or Python module
  • This change removes an existing class/function/struct/type from a public C header file or Python module

If any of the Backwards Incompatible check boxes are ticked please provide a justification why this change is necessary and why it needs to be done in a backwards incompatible way.

Review Status

@karl-wette @david-keitel should have a look at this change.

Merge request reports