Skip to content

Fix lalpulsar_MakeSFTDAG bugs

Evan Goetz requested to merge evan-goetz/lalsuite:sftdag-window-fix into master

Description

This MR fixes two lalpulsar_MakeSFTDAG.py bugs:

  • removes required=True for --window-type now that default="tukey:0.001" is specified
  • cast window parameter to float instead of string when writing variables to dag file

These are needed for correct logical operations using the MakeSFTDAG workflow.

API Changes and Justification

Backwards Compatible Changes

  • This change does not modify any class/function/struct/type definitions in a public C header file or any Python class/function definitions
  • This change adds new classes/functions/structs/types to a public C header file or Python module

Backwards Incompatible Changes

  • This change modifies an existing class/function/struct/type definition in a public C header file or Python module
  • This change removes an existing class/function/struct/type from a public C header file or Python module

If any of the Backwards Incompatible check boxes are ticked please provide a justification why this change is necessary and why it needs to be done in a backwards incompatible way.

Review Status

@david-keitel @karl-wette @john-whelan please take a look

Merge request reports