Skip to content

SEOBNRv5EHM support in gwsignal

Raffi Enficiaud requested to merge raffi.enficiaud/lalsuite:v5ehm_rebased into master

Description

This PR adds support of the model SEOBNRv5EHM into GWSignal. As the review of SEOBNRv5EHM in pyseobnr is complete, support in GWSignal is required in order to use the model from a standard interface and for doing PE.

The implementation provides a new class dedicated to the model and has no impact on the previous models.

Note: this implementation has been tested during the review through the task of paramter estimation. It requires additional changes to bilby that are pending, but the work here can be merged independantly of pyseobnr and bilby.

API Changes and Justification

Backwards Compatible Changes

  • This change does not modify any class/function/struct/type definitions in a public C header file or any Python class/function definitions
  • This change adds new classes/functions/structs/types to a public C header file or Python module

Backwards Incompatible Changes

  • This change modifies an existing class/function/struct/type definition in a public C header file or Python module
  • This change removes an existing class/function/struct/type from a public C header file or Python module

Review Status

The review statement is here: https://git.ligo.org/waveforms/reviews/seobnrv5ehm/-/wikis/home#review-statement

The review chair was @geraint.pratten , and reviewers were:

Merge request reports