Skip to content

Remove the nosfts output from lalpulsar_MakeSFTs and allow channel skipping in Fscan programs

Evan Goetz requested to merge evan-goetz/lalsuite:rem-nosfts into master

Description

This MR removes the nosfts file output from lalpulsar_MakeSFTs if that program was given the --allow_skipping=TRUE option. Instead we spread to the other Fscan programs the --allow_skipping option so that the program is more robust to no SFT files potentially being present and we will instead rely on the parent-child relationship of the Fscan DAG workflow.

API Changes and Justification

Backwards Compatible Changes

  • This change does not modify any class/function/struct/type definitions in a public C header file or any Python class/function definitions
  • This change adds new classes/functions/structs/types to a public C header file or Python module

Backwards Incompatible Changes

  • This change modifies an existing class/function/struct/type definition in a public C header file or Python module
  • This change removes an existing class/function/struct/type from a public C header file or Python module

In the rare case (Fscans only) where --allow_skipping=TRUE was provided, then the function to make the nosfts file was called. I have removed this function because I don't want to worry about using the HTCondor file transfer system to transfer this file back to the home filesystem

Review Status

No review started yet. I need to discuss this MR further with @karl-wette @ansel-neunzert

Edited by Karl Wette

Merge request reports