Skip to content

lalapps: remove src/inspiral/calcexpsnr.c

Kipp Cannonrequested to merge
kipp/lalsuite:lal_LALStatus_cleanup into master

Description

Incremental progress on the removal of the LALStatus structure from lalsuite.

  • from lalapps remove obsolete and unmaintained src/inspiral/calcexpsnr.c
  • that was the only user of several LALStatus based I/O routines in lal/lib/support, which are removed
  • code in question is two-column ascii time series and frequency series reading and writing
  • python numpy can replace the features in the code that is removed

API Changes and Justification

Backwards Compatible Changes

  • This change does not modify any class/function/struct/type definitions in a public C header file or any Python class/function definitions
  • This change adds new classes/functions/structs/types to a public C header file or Python module

Backwards Incompatible Changes

  • This change modifies an existing class/function/struct/type definition in a public C header file or Python module
  • This change removes an existing class/function/struct/type from a public C header file or Python module

If any of the Backwards Incompatible check boxes are ticked please provide a justification why this change is necessary and why it needs to be done in a backwards incompatible way.

It's not "necessary" to remove obsolete and unmaintained code. It's just a drag on development to have to keep ensuring it compiles.

Review Status

not reviewed.

Merge request reports