Skip to content

Remove version check for SEOBNR models

Detailed Description

This MR addresses an issue where the file attributes version_major, version_minor, and version_micro are stored as int64 in the HDF5 file for some waveform data files, while this function expects an int32 type (see waveforms/software/lalsuite-waveform-data#1). This causes compatibility issues on certain systems (e.g., ARM64). The same issue is present in the latest version of other SEOBNR ROM files.

Rather than creating a new version of these files for such a minor change - which would require a version update and break compatibility with previous files - I propose removing the check of the version numbers. This check is not performed for other waveform models (e.g., the NRSur ones), is not required for CVMFS distribution, and is redundant since versioning is already contained in both the filename and the CANONICAL_FILE_BASENAME attribute, which is verified when reading the data.

API Changes

  • These changes do not modify the API.
  • These changes are backwards compatible.
  • These changes are backwards incompatible.

For examples of changes that do not modify the API and/or are considered backwards (in)compatible, please see the contributing guide.

Justification for Backwards Incompatible Changes

Review Status

Merge request reports

Loading