Skip to content
Snippets Groups Projects

eliminate most glue dependencies by migrating pipeline.py from gstlal

Merged eliminate most glue dependencies by migrating pipeline.py from gstlal
kipp/lalsuite:pipeline.py into master
Merged Kipp Cannon requested to merge kipp/lalsuite:pipeline.py into master

Detailed Description

This is some packaging house-keeping. With only two exceptions, the only actual dependency lalsuite has on the old glue package is the "pipeline.py" module. That module had originally been developed under the lalsuite umbrella but was moved to glue when that project was created. It came to be unmaintained for a long time, for example it didn't get ported to python 2 when that was needed, so the gstlal project forked it and maintained a working version locally. This patch set copies pipeline.py from gstlal into lalsuite, and replaces the glue.pipeline imports found in several lalsuite packages with lal.pipeline imports. Finally, the version from glue is merged back into the module so that it provides the same API as that module (not that anything needs it, just for posterity). That almost completely decouples lalsuite from the glue package. Since pipeline.py in glue was non-functional for many years when Python 2 became unavailable, clearly the codes in lalsuite that rely on it are not used regularly and are therefore almost certainly bit-rotted in other ways. I make no guarantees that these patches leave any of them in a working state. It is left as an exercise for the maintainers of the DAG scripts to resurrect them if needed. I can speak about the cosmic string pipeline, one of the DAG scripts affected: the production version of that pipeline is not on master or even in lscsoft's lalsuite, it lives in a branch in a forked tree, but that came to be mostly because of the breakage related to glue and python 2; this work might facilitate the production version of that pipeline being brought back onto lalsuite's mainline tree.

API Changes

Please tick one of the following options:

  • These changes do not modify the API.
  • These changes do modify the API, and are backwards compatible.
  • These changes do modify the API, and are backwards incompatible.

No existing API is modified, but pipeline.py is added to lal's Python namespace.

Justification for Backwards Incompatible Changes

N/A

Review Status

These patches are not reviewed. I believe the affected codes in lalsuite are bit-rotted and non-functional. It's possible that this new pipeline.py version is enough to fix some of them. The pipeline.py module from gstlal has been and is used for production running, and that pipeline is reviewed. The pipeline.py version that appears here differs from that version only by the addition of a few classes from the glue version and in whitespace changes.

Edited by Kipp Cannon

Merge request reports

Merged results pipeline #715374 passed with warnings

Stage: tarballs
Stage: LAL
Stage: LALFrame
Stage: LALMetaIO
Stage: LALSimulation
Stage: LALBurst
Stage: LALInspiral
Stage: LALInference
Stage: LALPulsar
Stage: LALApps
Stage: wheels
Stage: integration tests
Stage: compiler tests
Stage: platform tests
Stage: upgrade tests
Stage: coverage
Stage: lint
Stage: documentation

Merged results pipeline passed with warnings for a75680bd

Approval is optional
Ready to merge by members who can write to the target branch.

Merge details

  • 2 commits and 1 merge commit will be added to master.
  • Source branch will not be deleted.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply