Skip to content
Snippets Groups Projects

lal: remove ReadFTSeries module

Merged Kipp Cannon requested to merge kipp/lalsuite:lal_remove_ReadFTSeries into master

Detailed Description

lal: remove unused ReadFTSeries module

  • I/O code to support a delimited ascii format
  • while these are potentially useful, there are not currently any use cases for it, and this particular implementation is based on the obsolete LALStatus-based API.
  • the only remaining code in lalsuite to have used these particular functions was lalapps/src/inspiral/calcexpsnr.c (lalapps_calcexpsnr) which was recently removed.
  • after this code is removed, there are other tools elsewhere able to deal with this format if needed. for example, gstlal provides the tsvdec element to convert two-column ascii text time series into audio streams (and from there it can be whitened, have injections added, be written to frame files, etc.). numpy can load such a file into a python array object, and, for example, together with lal's series.py can be used to convert two-column ascii psds into xml format.

This is the second half of !2405 (closed)

API Changes

Please tick one of the following options:

  • These changes do not modify the API.
  • These changes do modify the API, and are backwards compatible.
  • These changes do modify the API, and are backwards incompatible.

For examples of changes that do not modify the API and/or are considered backwards (in)compatible, please see the contributing guide.

Justification for Backwards Incompatible Changes

The patch removes functions from lal that require the LALStatus object for error reporting. No new code should have been written using this API style since ca. 2005, and nothing in lalsuite currently uses this set of functions.

Review Status

Not reviewed.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
Please register or sign in to reply
Loading