Skip to content
Snippets Groups Projects

Correct doc strings for Tempo par file reader and add additional parameters

Merged Matthew Pitkin requested to merge matthew-pitkin/lalsuite:add_tempo_par_parameters into master
All threads resolved!

Detailed Description

The doc strings for the parameters BETA and LAMBDA that can be read in from a Tempo-style parameter file are currently wrong - the doc strings states that these are Galactic latitude and longitude, when really they are just aliases for the ELAT and ELONG values, which are the ecliptic coordinates (see Table 2 of the Tempo2 manual). This MR corrects these doc strings.

In addition, it also adds in the ability to read in a couple of other potentially useful parameters from a par file (TIMEEPH and T2CMETHOD) and add checks to the test code to read in some additional parameters.

API Changes

Please tick one of the following options:

  • These changes do not modify the API.
  • These changes do modify the API, and are backwards compatible.
  • These changes do modify the API, and are backwards incompatible.

For examples of changes that do not modify the API and/or are considered backwards (in)compatible, please see the contributing guide.

Justification for Backwards Incompatible Changes

Review Status

cc @david-keitel @karl-wette

Merge request reports

Merged results pipeline #715403 passed with warnings

Merged results pipeline passed with warnings for b22229f3

Code Quality is loading
Test summary results are being parsed

Merged by David KeitelDavid Keitel 2 weeks ago (Mar 26, 2025 6:34am UTC)

Loading

Pipeline #716725 failed

Pipeline failed for c7d91906 on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading