Skip to content

CI: install build dependencies in top-level (make distcheck) jobs

Karl Wetterequested to merge
ANU-CGA/lalsuite:top-level-build-deps into master

Detailed Description

The top-level (make distcheck) CI jobs do not currently attempt to ensure that all build dependencies are satisfied, instead relying on the underlying Docker image being up to date. This is a problem when an MR (e.g. !2449 (merged)) tries to add a dependency on a new package that isn't installed in the Docker images; the CI will fail until the Docker image is updated.

This MR creates two new CI templates derived from .make-distcheck:

  • .make-distcheck-deb installs build dependencies on Debian images, using apt-get build-dep .
  • .make-distcheck-rpm installs build dependencies on RHEL images, using yum-builddep

Both templates avoid installing any packages from LALSuite itself as build dependencies; any package matching lal*, liblal* or python*-lal* are filtered out of debian/control (for Debian) or lal*.spec (for RHEL). This makes sure that the top-level CI jobs check that LALSuite builds properly without needing to install itself first.

API Changes

Please tick one of the following options:

  • These changes do not modify the API.
  • These changes do modify the API, and are backwards compatible.
  • These changes do modify the API, and are backwards incompatible.

For examples of changes that do not modify the API and/or are considered backwards (in)compatible, please see the contributing guide.

Justification for Backwards Incompatible Changes

n/a

Review Status

n/a

Merge request reports