Skip to content

LALInferenceGenerateROQ: change to using iterated Gram-Schmidt algorithm from greedycpp

Matthew Pitkin requested to merge matthew-pitkin/lalsuite:ppe_roq_update into master

This branch contains updates to the LALInference ROQ code to use the iterated Gram-Schmidt algorithm used in the greedycpp code. This should be more numerically stable.

With the changes the test code LALInferenceGenerateROQTest still passes, and I've also compared this to the output of the greedycpp with the same test model added, and have verified that it produces equivalent results.

These changes mean that the functions in lalapps/src/pulsar/HeterodyneSearch/ppe_roq.c have also had to be modified. I have checked that these give consistent results to the non-ROQ code using the example here.

cc - PE chairs and code zsars @vivien, @bfarr, @john-veitch, also @rory-smith who had reviewed this in the past.

Merge request reports