Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • lalsuite lalsuite
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 110
    • Issues 110
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 35
    • Merge requests 35
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • lscsoft
  • lalsuitelalsuite
  • Merge requests
  • !43

LALInferenceGenerateROQ: change to using iterated Gram-Schmidt algorithm from greedycpp

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Matthew Pitkin requested to merge matthew-pitkin/lalsuite:ppe_roq_update into master Dec 22, 2017
  • Overview 0
  • Commits 1
  • Pipelines 1
  • Changes 5

This branch contains updates to the LALInference ROQ code to use the iterated Gram-Schmidt algorithm used in the greedycpp code. This should be more numerically stable.

With the changes the test code LALInferenceGenerateROQTest still passes, and I've also compared this to the output of the greedycpp with the same test model added, and have verified that it produces equivalent results.

These changes mean that the functions in lalapps/src/pulsar/HeterodyneSearch/ppe_roq.c have also had to be modified. I have checked that these give consistent results to the non-ROQ code using the example here.

cc - PE chairs and code zsars @vivien, @bfarr, @john-veitch, also @rory-smith who had reviewed this in the past.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: ppe_roq_update