Skip to content

LALInferenceGenerateROQ.c: check normalisation of new basis is not zero

Matthew Pitkin requested to merge matthew-pitkin/lalsuite:roq_zero_check into master

If a new basis is entirely encompassed within the current basis within numerical precision it can consist entirely of zeros. When normalising a basis vector of zeros it leads to a basis of NaNs, which gets added to the current basis set. This will give NaN values in likelihoods calculated using the ROQ. This patch checks if the normalisation has become a NaN (due to a zerod basis) and if so will not add the new basis to the current basis as it is unnecessary.

@karl-wette @david-keitel @john-veitch - would one of you be able to merge this?

Edited by Ghost User

Merge request reports