Skip to content

update lalapps/src/pulsar uvar defaults to 00-40 ephems

David Keitel requested to merge CW/software/lalsuite:update-default-ephems into master

Since 2020 is not far away anymore, I've replaced all earth00-19 and sun00-19 user-variable defaults with Matt's new earth00-40 and sun00-40 files from !187 (merged), not changing the default DE4** version as discussed in CW#47.

Notes:

  1. I haven't touched any of the test codes in lalpulsar, though long-term we might want to also migrate those to the 00-40 files and phase out the shorter ones.
  2. @matthew-pitkin please have a somewhat closer look at the various files touched in HeterodyneSearch, as I'm not sure how many of these are covered by unit tests, and some do slightly more complicated version acrobatics.
  3. @karl-wette the only code I've not touched is Weave/WeaveSetup.c because, doing the same change as elsewhere, it gave me test failures
FAIL: TestInterpolating.sh
FAIL: TestNonInterpolating.sh
FAIL: TestSingleSegment.sh
PASS: TestSimulateSearch.sh
PASS: TestCacheMaxSize.sh
PASS: TestCheckpointing.sh
PASS: TestPartitioning.sh

and a 38MB-sized test-suite.log with many instances of:

Mismatched coordinates: check if one of the two ranking statistics was close to the toplist effective 'threshold'
Negative: failed comparison

If you'd have a chance to look into this quickly, we could still include a fix in this MR; if not, I'll just make a separate reminder issue for you.

Edited by Karl Wette

Merge request reports