Skip to content

MFD: deprecate transientTauDays

David Keitel requested to merge david-keitel/lalsuite:MFD-deprecate-transientTauDays into master 
XLALReadPulsarParams: switch recommended usage to transientStartTime, transientTau in integer seconds
    
     -these were internally rounded to UINT4 already,
      better to be upfront with it!
     -transientTauDays kept for backwards compatibility for now,
      but throw deprecation warning

The idea is to deprecate the Days version for now, then quite soon to remove it together with the equivalent in CFSv2 which I already deprecated >2 years ago 86ee450a . It's cluttering up CFSv2 input/output too much, but it'll be better to have an intermediate version where both the injection and search code support both formats.

cc @adam-mercer because in the first commit on this branch, I add new UINT(4,8) parsing options to ConfigFile.(ch) in lal, simply duplicating the existing macros for INT(4,8). I'm actually quite surprised they didn't exist yet...

Merge request reports