Skip to content

lalapps/src/inspiral: remove lalapps_trigbank

Kipp Cannon requested to merge (removed):remove_trigbank into master

Summary

remove lalapps_trigbank

Description

  • this program is abandonware from the defunct ihope pipeline. it was used to construct a hierarchical pipeline in which a first pass to produce triggers and coincidences was followed by a second pass, this time with \chi^2 calculations enabled and using only templates that were known to have produced coincidences the first time around
  • the program is now broken: modern template banks encode each template's merger reference time in the end-time columns, and this program fails to reconstruct this information.
  • why not fix it? because this operation of constructing a template bank from a collection of triggers has no place in modern pipelines, which operate with so low an SNR threshold that all templates always produce triggers, which require uniformly sampled template banks for noise model construction, and in which \chi^2 calculations have been moved in-line as part of the trigger production and are no longer a significant additional cost.
  • why not leave it? that's how you get pylal. this program is 100% obsolete LALStatus based code, and as such is impeding clean-ups elsewhere in lalsuite.

API Changes and Justification

Backwards Compatible Changes

  • This change introduces no API changes
  • This change adds new API calls

Backwards Incompatible Changes

  • This change modifies an existing API
  • This change removes an existing API

Review Status

N/A

Edited by LALSuite Bot

Merge request reports