Skip to content

Change normed to density in numpy and matplotlib histograms within LALInference

Description

The use of the argument normed=True in histograms from matplotlib and numpy is deprecated since a few versions ago in either package. This leads to warnings like

/home/soichiro.morisaki/local/gwcelery_envs/gwcelery_lalsuite659/lib/python3.6/site-packages/lalinference/bayespputils.py:3987: MatplotlibDeprecationWarning:
The 'normed' kwarg was deprecated in Matplotlib 2.1 and will be removed in 3.1. Use ‘density’ instead.
  (n, bins, patches)=plt.hist(pos_samps,histbins,normed='true',facecolor=‘grey’)
Generating 1D plot for a1z.

but it's easily fixed by switching to density=True for all these instances.

API Changes and Justification

Backwards Compatible Changes

  • This change introduces no API changes
  • This change adds new API calls

Backwards Incompatible Changes

  • This change modifies an existing API
  • This change removes an existing API

It technically breaks backwards compatibility with numpy versions from 1.5 and backwards (Numpy 1.5 was released in 2010). It also breaks compatibility with matplotlib 2.0 (released in 2017).

Review Status

Merge request reports