Skip to content

move LALFindChirpTDTemplate(), LALFindChirpSPTemplate() to lalapps

Kipp Cannon requested to merge (removed):move_findchirptemplt_to_lalapps into master

Description

Move two obsolete waveform functions from lalinspiral to lalapps, and compile directly into the two programs that use them.

API Changes and Justification

Backwards Compatible Changes

  • This change introduces no API changes
  • This change adds new API calls

Backwards Incompatible Changes

  • This change modifies an existing API
  • This change removes an existing API

These two functions are mostly abandoned and possibly even "incorrect" (one claims to correspond to a compact object inspiral waveform model that a newer function in lalsimulation generates, and I would estimate the odds of them agreeing to be nearly 0, and disagreement with lalsimulation is generally taken to be equivalent to "incorrect"). The only code that calls these functions is the coh_PTF code in lalapps whose owners report their development to have shifted to a different repository. This patch moves the functions out of lalinspiral, to live with the calling code in lalapps, where they get compiled directly into the programs that use them, to be henceforth maintained or deleted as the coh_PTF code owners wish.

Review Status

Not reviewed. Build succeeds.

Merge request reports