Skip to content

Use explicitly LAL_SIM_INSPIRAL_TIDAL_ORDER_6PN in SEOBNRv4T_surrogate

Sylvain Marsat requested to merge sylvain.marsat/lalsuite:SEOBNRv4T_surrogate_explicitTidalPNorder into master

Description

The Waveform approximant SEOBNRv4T_surrogate relies on TF2 internally: what is modelled is the difference between SEOBNRv4T and TF2 with tidal terms at 5PN and 6PN.

Previously, when setting the PN coefficients, the code did not ask explicitly for a LAL_SIM_INSPIRAL_TIDAL_ORDER thus using the default, currently 7PN. Later, when actually computing the phasing from the coeffs, only the 5PN and 6PN were used.

This is consistent with what is itended, but relies on the default tidal PN order for TF2 to be >=6PN.

This commit asks explicitly for LAL_SIM_INSPIRAL_TIDAL_ORDER_6PN, not relying on the default anymore and making the code more robust against future changes in TF2.

API Changes and Justification

Backwards Compatible Changes

  • This change introduces no API changes
  • This change adds new API calls

Backwards Incompatible Changes

  • This change modifies an existing API
  • This change removes an existing API

Review Status

Merge request reports