Skip to content

lalapps_inspfrinj: replace LALSSInjectTimeSeries()

Kipp Cannon requested to merge (removed):inspfrinj_port_to_addreal4timeseries into master

Description

This replaces LALSSInjectTimeSeries() in lalapps_inspfrinj with XLALAddREAL4TimeSeries(). As far as I can tell, this code does not require the interpolating features of the SSInject function, it's only using it as an add operator, so this patch replaces the function call with the add operator for these data types, which brings with it additional safety checks that the two time series are compatible with each other. If interpolation is required, XLALSimAddInjectionREAL4TimeSeries() should be used, but no matter what LALSSInjectTimeSeries() should not be used in any current code.

API Changes and Justification

Backwards Compatible Changes

  • This change introduces no API changes
  • This change adds new API calls

Backwards Incompatible Changes

  • This change modifies an existing API
  • This change removes an existing API

Review Status

Not reviewed. I don't think the code in question is used anymore. The last evidence of a useage-induced change to this code was by Nick Fotopoulos in 2011. Either the code is perfect or nobody's using it.

Merge request reports