Skip to content

XLALComputeDetAMResponseExtraModes: fixed longitudinal normalization

Max Isi requested to merge max-isi/lalsuite:fix_longitudinal_ap into master

Description

Corrects the normalization of the longitudinal antenna pattern to agree with the convention for the other modes. The only change is a removal of a factor of LAL_SQRT2 that I incorrectly introduced many years ago. With this change, the breathing and longitudinal responses are equal and opposite (Fb = - Fl) as expected. As far as I'm aware, all analyses requiring scalar antenna patterns use Fb, so this change should not have any major consequences.

Note that this does not affect the usual plus and cross antenna patterns in any way.

API Changes and Justification

Backwards Compatible Changes

  • This change introduces no API changes
  • This change adds new API calls

Backwards Incompatible Changes

  • This change modifies an existing API
  • This change removes an existing API

Review Status

Maybe @matthew-pitkin wants to confirm this is correct.

Edited by Ghost User

Merge request reports