Skip to content

move LALSSInjectTimeSeries() to coh_PTF in lalapps

Kipp Cannon requested to merge (removed):move_lalssinjecttimeseries_to_coh_PTF into master

Description

coh_PTF is the now the only user of the LALSSInjectTimeSeries() routine and the functions that call it. This patch moves all of it from lalinspiral to lalapps to live with the coh_PTF code.

API Changes and Justification

Backwards Compatible Changes

  • This change introduces no API changes
  • This change adds new API calls

Backwards Incompatible Changes

  • This change modifies an existing API
  • This change removes an existing API

The LALSSInjectTimeSeries() routine was superseded by functions in lalsimulation many many years ago and should not be used for software injections. The coh_PTF code continues to use the function (the only code that still does). That decision is for the coh_PTF maintainers to make, but the function itself is inappropriate in a shared library where new users might mistake it for the correct way to do injections, therefore this match removes it from lalinspiral and places it with the coh_PTF code in lalapps. Future maintenance of this code is left to the coh_PTF developers.

Review Status

Patch has not been reviewed.

Merge request reports