Skip to content

Add a check for lambda1&lambda2 when using BinaryLove and margtime

Carl-Johan Haster requested to merge cjhaster/lalsuite:AllowBLandMargTime into master

Description

I noticed that runs with the BinaryLove tidal parameter model failed when running with the time marginalised likelihood. This appears to be caused by the first likelihood point not going through the WF functions in LALInferenceTemplate.c as I'd expect. All the parameters are there, but the function which does the translation from LambdaS, BLuni, q to lambda1, lambda2 is never activated. So, I've added a check for those parameters, and if they're not added I'll compute them.

Also, poing @john-veitch as the reviewer for the original BinaryLove MR !790 (merged)

API Changes and Justification

Backwards Compatible Changes

  • This change introduces no API changes
  • This change adds new API calls

Backwards Incompatible Changes

  • This change modifies an existing API
  • This change removes an existing API

Review Status

not reviewed

Merge request reports