Skip to content

Fix an incosistency in lalinference when amporder is nonzero

Serguei Ossokine requested to merge serguei.ossokine/lalsuite:fix_amp_order into master

Description

This patch fixes an inconsistency when using importer not equal to zero and time-domain, precessing EOB models. The inconsistency arises because for such EOB models, the spins must always be defined at the starting frequency of the waveform. Meanwhile, in lalinference the function that transforms from tilt angles, etc to Cartesian spin components was called at fRef which (especially when amporder is not zero) will be different from fStart. This patch checks whether the template is a time-domain, precessing EOB model and if so, ensures that the transformation function is called with the correct frequency, i.e. fStart. This change should only affect precessing EOB models.

API Changes and Justification

Backwards Compatible Changes

  • This change introduces no API changes
  • This change adds new API calls

Backwards Incompatible Changes

  • This change modifies an existing API
  • This change removes an existing API

Review Status

Not associated with a review

Merge request reports