GitLab

Description

Most of the plotting scripts in lalinference.plot are not used by anything in LALInference. On import of that package, an deprecation warning is printed

(ligo-py36) [carl-johan.haster@ldas-pcdev5]$ python
Python 3.6.7 | packaged by conda-forge | (default, Jul  2 2019, 02:18:42)
[GCC 7.3.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import lalinference.plot
__main__:1: MovedWarning: "lalinference.plot" has moved to ligo.skymap.

The lalinference.plot module from LALInference has been replaced by
the ligo.skymap.plot module from the ligo.skymap package. The old
module is no longer tested and supported and will be removed in a
future version of LALInference. Please update to the ligo.skymap
package.

You can install ligo.skymap with pip by running this command in your
shell:

    pip install ligo.skymap

but since all dependencies that are actually informed by this message have been solved (skymap plots are done through ligo.skymap). So, the only script that is actually used from lalinference.plot is spindisk.py which is not dependent on ligo.skymap, so there's no need to print that warning anymore.

Hence, this MR removes all the code that is no longer used (and is intended not to be used going forward either), and removes the lines that prints the warning on import of lalinference.plot

ping @leo-singer @vivien @bfarr

API Changes and Justification

Backwards Compatible Changes

• This change introduces no API changes
• This change adds new API calls

Backwards Incompatible Changes

• This change modifies an existing API
• This change removes an existing API

justification given in description above

Review Status

no review needed (apart from the general review of the MR)