Skip to content

LALSimInspiralChooseFDWaveformFromCache: pass LALpars in default case

John Douglas Veitch requested to merge john-veitch/lalsuite:michalis_tweet_issue_195 into master

Description

As per issue #195 (closed), @michalis-agathos writes

At the very bottom of XLALSimInspiralChooseFDWaveformFromCache() there is a call to XLALSimInspiralChooseFDWaveform() which passes NULL instead of the LALDict pointer LALpars:

        else {
	  return XLALSimInspiralChooseFDWaveform(hptilde, hctilde, m1, m2,
						 S1x, S1y, S1z, S2x, S2y, S2z,
						 r, i, phiRef, 0., 0., 0.,
						 deltaF, f_min, f_max, f_ref,
						 NULL, approximant);
        }
    }

This may silently affect LALInference runs by setting optional parameters to default values, or may cause segfaults e.g. in the case the generator calls "Insert" LALDict functions internally.

API Changes and Justification

Backwards Compatible Changes

  • This change introduces no API changes
  • This change adds new API calls

Backwards Incompatible Changes

  • This change modifies an existing API
  • This change removes an existing API

Review Status

Edited by John Douglas Veitch

Merge request reports