Renaming non-precessing remnant quantities

The purpose of this MR is to rename the non-precessing remnant quantities from "{}_non_evolved" to "{}" as the spin evolved quantities for non-precessing systems are equivalent to the non_evolved quantities. It also includes code updates to calculate the remnant properties of non-spinning systems.

pesummary/gw/file/conversions.py

@@ -1397,6 +1397,9 @@ class _Conversion(object):
         self.redshift_method = redshift_method
         self.cosmology = cosmology
         self.force_non_evolved = force_non_evolved
+        self.non_precessing = False
+        if not any(param in self.parameters for param in conf.precessing_angles):
+            self.non_precessing = True
         if self.regenerate is not None:
             for param in self.regenerate:
                 self.remove_posterior(param)
@@ -2072,7 +2075,7 @@ class _Conversion(object):
             logger level to use for information
         """
         if old in self.parameters:
-            ind = self.parameters.index("old")
+            ind = self.parameters.index(old)
             self.parameters[ind] = new
             getattr(logger, logger_level)(
                 "Renaming the {} posterior to {}".format(old, new)
@@ -2344,7 +2347,7 @@ class _Conversion(object):
             "spin_1z_evolved", "spin_2z_evolved", "reference_frequency",
             "minimum_frequency"
         ]
-        if not any(param in self.parameters for param in conf.precessing_angles):
+        if self.non_precessing:
             rename = [
                 "final_mass_non_evolved", "final_spin_non_evolved",
                 "peak_luminosity_non_evolved", "final_mass_source_non_evolved",