Renaming non-precessing remnant quantities
All threads resolved!
All threads resolved!
The purpose of this MR is to rename the non-precessing remnant quantities from "{}_non_evolved" to "{}" as the spin evolved quantities for non-precessing systems are equivalent to the non_evolved quantities. It also includes code updates to calculate the remnant properties of non-spinning systems.
Edited by Charlie Hoy
Merge request reports
Activity
added 1 commit
- 940c49b5 - fixing evolve spins for non-precessing system
added 3 commits
-
940c49b5...f695ce22 - 2 commits from branch
master - 3f038694 - merge in master
-
940c49b5...f695ce22 - 2 commits from branch
The CI is expected to fail for the
Bilbyconsequences job because of bilby#489 (closed). However, if the CI passes for all other jobs, this is ready to be merged (subject to passing review).added 1 commit
- d6aecae0 - updating to account for non-spinning systems
added 1 commit
- f30fbce9 - changing logic slightly to only add spin_1z, spin_2z sampleS
mentioned in commit 2355b7dd
Please register or sign in to reply