Skip to content

Changes

Page history
Linking the chat authored by Nathan Johnson-McDaniel's avatar Nathan Johnson-McDaniel
Show whitespace changes
Inline Side-by-side
Remnant-fits.md
View page @ 251e4edd
......@@ -309,7 +309,7 @@ Maximum difference for af_evol_avg: 9.770286555355057e-07
## Review comments
* see in-line discussion threads on !245
* most other comments were resolved through the Mattermost chat. Some important topics/decisions:
* most other comments were resolved through the [Mattermost chat](https://chat.ligo.org/ligo/channels/bbh-remnant-fits). Some important topics/decisions:
* The last remaining differences against Nathan's reference implementation were traced down to different q -> (m1,m2) treatments between PESummary and lalinferences.bayespputils, nothing to do with the NR fits or spin evolution, though the spin evolution does amplify the differences: Very small differences in m1,m2 (~1e-14) caused much larger differences (~1e-4) in the evolved spins.
* It was decided to only add a `_non_evolved` suffix if applicable, with evolved quantities being, e.g., just `final_spin` without a suffix, to make life easier for external non-expert users of the released meta files.
* For the same reason, the evolved angles are not stored in the final output file.
......