| ... | ... | @@ -60,7 +60,7 @@ Comments on the revised version |
|
|
|
|
|
|
|
* [nrutils.py](https://git.ligo.org/lscsoft/pesummary/-/blob/review_comments/pesummary/gw/file/nrutils.py)
|
|
|
|
- [ ] Is there any reason to keep the (nonspinning) Pan et al. fit in `FinalSpinPrecessingFits` ([here](https://git.ligo.org/lscsoft/pesummary/-/blob/review_comments/pesummary/gw/file/nrutils.py#L479))?
|
|
|
|
- [ ] The `_bbh_final_spin_precessing_projected()` function's [documentation](https://git.ligo.org/lscsoft/pesummary/-/blob/review_comments/pesummary/gw/file/nrutils.py#L279) needs to mention the augmentation with the in-plane spins
|
|
|
|
- [x] The `_bbh_final_spin_precessing_projected()` function's [documentation](https://git.ligo.org/lscsoft/pesummary/-/blob/review_comments/pesummary/gw/file/nrutils.py#L279) needs to mention the augmentation with the in-plane spins
|
|
|
|
|
|
|
|
* Possibly for the future
|
|
|
|
- [ ] I would recommend changing the `Healyetal` fit name (e.g., [here](https://git.ligo.org/lscsoft/pesummary/-/blob/review_comments/pesummary/gw/file/nrutils.py#L53)) to something more descriptive, likely involving the year, since there is also a Healy, Lousto, and Zlochower fit, and more than one Healy and Lousto fit (and possibly more such fits in the future). However, the naming can probably stay as is for the moment, unless David has strong feelings about this.
|
| ... | ... | @@ -70,7 +70,7 @@ Comments on the revised version |
|
|
|
- [x] The `_final_from_initial()` function's [documentation](https://git.ligo.org/lscsoft/pesummary/-/blob/review_comments/pesummary/gw/file/conversions.py#L395) should make it clear that in the precessing case it doesn't compute the final mass and spin the same way as in the waveform models (i.e., using the EOB fit evolution).
|
|
|
|
|
|
|
|
* Minor:
|
|
|
|
- [ ] ["fit you wish to you"](https://git.ligo.org/lscsoft/pesummary/-/blob/review_comments/pesummary/gw/file/conversions.py#L460); also [here](https://git.ligo.org/lscsoft/pesummary/-/blob/review_comments/pesummary/gw/file/conversions.py#L496)
|
|
|
|
- [x] ["fit you wish to you"](https://git.ligo.org/lscsoft/pesummary/-/blob/review_comments/pesummary/gw/file/conversions.py#L460); also [here](https://git.ligo.org/lscsoft/pesummary/-/blob/review_comments/pesummary/gw/file/conversions.py#L496)
|
|
|
|
|
|
|
|
* For the future
|
|
|
|
- [ ] This should only apply the BBH fits if there are no tidal deformability samples present (this will be necessary on the O3a catalogue timescale).
|
| ... | ... | |
