... | ... | @@ -23,6 +23,7 @@ However, continuing to read in [conversions.py](https://git.ligo.org/lscsoft/pes |
|
|
* [x] If those arguments to `_final_mass_of_merger` are changed, then probably in L1254f the param lists checking needs to be updated.
|
|
|
> See previous comment.
|
|
|
* [ ] There is this check `if all(i in self.parameters for i in final_params):` for calling `_final_spin_of_merger`. So what happens if the tilts are missing? No final spin computed at all? Shouldn't there be a non-precessing fallback?
|
|
|
> This has been corrected. See commit: cc5a6e59
|
|
|
|
|
|
* Higher level comments / looking ahead:
|
|
|
* [ ] How will the surrogates be called? Presumably something like `NRfit="NRSur7dq4"` instead of `NRfit="average"`? But it's not easy to see how this will be propagated up in the interface to user input.
|
... | ... | |