| ... | ... | @@ -166,7 +166,7 @@ Comments on the revised version |
|
|
|
* [x] Also I'm somewhat confused now when/where the explicit fit arguments are passed, and when not. From the main generate_all_posterior_samples, it calls e.g. _final_spin_of_merger, which then calls final_spin_of_merger, which then has defaults method="NR", approximant="SEOBNRv4", NRfit="average". So it currently always uses those defaults, is that right? Any other options would be a future MR?
|
|
|
|
--> answer from Charlie: "Yes so it currently uses those defaults. And yes, for interests of time, I will save other options for a future MR."
|
|
|
|
|
|
|
|
### sign-off
|
|
|
|
## sign-off
|
|
|
|
|
|
|
|
Nathan & David sign off on the version from !242 on 09 March 2020.
|
|
|
|
|
| ... | ... | @@ -184,7 +184,7 @@ Nathan & David sign off on the version from !242 on 09 March 2020. |
|
|
|
|
|
|
|
* see in-line discussion threads on !245
|
|
|
|
|
|
|
|
### sign-off
|
|
|
|
## sign-off
|
|
|
|
|
|
|
|
pending
|
|
|
|
|
| ... | ... | @@ -200,6 +200,6 @@ pending |
|
|
|
|
|
|
|
## Review comments
|
|
|
|
|
|
|
|
### sign-off
|
|
|
|
## sign-off
|
|
|
|
|
|
|
|
pending |
