| ... | ... | @@ -146,13 +146,13 @@ Comments on the revised version |
|
|
|
* For the future
|
|
|
|
- [ ] This should only apply the BBH fits if there are no tidal deformability samples present (this will be necessary on the O3a catalogue timescale).
|
|
|
|
- [ ] The `_final_from_initial()` function might also include `IMRPhenomD` as an option, interfacing with the Husa et al. fits used in this waveform.
|
|
|
|
- [ ] Similarly, one might allow for the other EOB models known by [here](https://git.ligo.org/lscsoft/pesummary/-/blob/review_comments/pesummary/gw/file/conversions.py#L403) (see [here](https://git.ligo.org/lscsoft/lalsuite/-/blob/master/lalsimulation/lib/LALSimBlackHoleRingdown.c#L717) and [here](https://git.ligo.org/lscsoft/lalsuite/-/blob/master/lalsimulation/lib/LALSimBlackHoleRingdownPrec.c#L39))
|
|
|
|
- [ ] Similarly, one might allow for the other EOB models known by the LALSimulation functions called by `_final_from_initial` [here](https://git.ligo.org/lscsoft/pesummary/-/blob/review_comments/pesummary/gw/file/conversions.py#L403) (see [here](https://git.ligo.org/lscsoft/lalsuite/-/blob/master/lalsimulation/lib/LALSimBlackHoleRingdown.c#L717) and [here](https://git.ligo.org/lscsoft/lalsuite/-/blob/master/lalsimulation/lib/LALSimBlackHoleRingdownPrec.c#L39))
|
|
|
|
|
|
|
|
* [latex_labels.py](https://git.ligo.org/lscsoft/pesummary/-/blob/review_comments/pesummary/gw/plots/latex_labels.py)
|
|
|
|
* Minor:
|
|
|
|
- [ ] There should be a space between ergs and s^{-1} [here](https://git.ligo.org/lscsoft/pesummary/-/blob/review_comments/pesummary/gw/plots/latex_labels.py#L84). Additionally, things like "peak," "nonevol," "ergs," and "s" should all be set in Roman.
|
|
|
|
|
|
|
|
### David Keitel 2020.03.04
|
|
|
|
### David Keitel 2020.03.09
|
|
|
|
* From Nathan:
|
|
|
|
> The _final_from_initial() function might also include IMRPhenomD as an option, interfacing with the Husa et al. fits used in this waveform.
|
|
|
|
|
| ... | ... | |
