Skip to content

Changes

Page history
Update Remnant fits authored by Charlie Hoy's avatar Charlie Hoy
Show whitespace changes
Inline Side-by-side
Remnant-fits.md
View page @ 67bbbe08
......@@ -22,7 +22,7 @@ However, continuing to read in [conversions.py](https://git.ligo.org/lscsoft/pes
> Tilt angles are not required for PESummary because `spin_1z` and `spin_2z` are already precomputed and can be passed directly.
* [x] If those arguments to `_final_mass_of_merger` are changed, then probably in L1254f the param lists checking needs to be updated.
> See previous comment.
* [ ] There is this check `if all(i in self.parameters for i in final_params):` for calling `_final_spin_of_merger`. So what happens if the tilts are missing? No final spin computed at all? Shouldn't there be a non-precessing fallback?
* [x] There is this check `if all(i in self.parameters for i in final_params):` for calling `_final_spin_of_merger`. So what happens if the tilts are missing? No final spin computed at all? Shouldn't there be a non-precessing fallback?
> This has been corrected. See commit: cc5a6e59
* Higher level comments / looking ahead:
......