| ... | @@ -27,4 +27,5 @@ However, continuing to read in [conversions.py](https://git.ligo.org/lscsoft/pes |
... | @@ -27,4 +27,5 @@ However, continuing to read in [conversions.py](https://git.ligo.org/lscsoft/pes |
|
|
|
|
|
|
|
* Higher level comments / looking ahead:
|
|
* Higher level comments / looking ahead:
|
|
|
* [ ] How will the surrogates be called? Presumably something like `NRfit="NRSur7dq4"` instead of `NRfit="average"`? But it's not easy to see how this will be propagated up in the interface to user input.
|
|
* [ ] How will the surrogates be called? Presumably something like `NRfit="NRSur7dq4"` instead of `NRfit="average"`? But it's not easy to see how this will be propagated up in the interface to user input.
|
|
|
|
> The main way that people will use this conversion function is through the command line tool `summarypages`. Therefore I think the best way would be to add a new command line argument `--NRSur-fit` which will use the NRSur fits.
|
|
|
* [ ] Similar for the spin evolution, I see that various functions already have a `evolved=False` placeholder switch, but how will that actually be decided? Will `generate_all_posterior_samples` get an extra switch argument (or as part of `self`), or will the evolved samples be generated in a step prior to calling this function and it will check for their presence, then use them if available? |
|
* [ ] Similar for the spin evolution, I see that various functions already have a `evolved=False` placeholder switch, but how will that actually be decided? Will `generate_all_posterior_samples` get an extra switch argument (or as part of `self`), or will the evolved samples be generated in a step prior to calling this function and it will check for their presence, then use them if available? |
|
|
|
\ No newline at end of file |
