... | ... | @@ -17,7 +17,7 @@ However, continuing to read in [conversions.py](https://git.ligo.org/lscsoft/pes |
|
|
* [conversions.py](https://git.ligo.org/lscsoft/pesummary/-/blob/master/pesummary/gw/file/conversions.py)
|
|
|
* [ ] `final_mass_of_merger_from_NR` and `final_mass_of_merger` take `final_spin` arguments (presumably for the Healy et al fits), but don't pass them on. Since these extra arguments are only used in nrutils for minor speedup, this is probably not a problem, but it looks odd; maybe just drop them from your local interface?
|
|
|
* [x] Why do `final_mass_of_merger_from_NR` and `final_spin_of_merger_from_NR`, when not in the "average" case, always call the respective `non_precessing` functions?
|
|
|
> For the `final_mass_of_merger_from_NR`, the only available fits are `non_precessing` so that is why it only called `non_precessing` fits. I have corrected the `final_spin_of_merger_from_NR` to allow for precessing fits. This is done by prepending the `NRfit` by `precessing_`.
|
|
|
> For the `final_mass_of_merger_from_NR`, the only available fits are `non_precessing` so that is why it only called `non_precessing` fits. I have corrected the `final_spin_of_merger_from_NR` to allow for precessing fits. This is done by prepending the `NRfit` by `precessing_`. See commit: 7c57bdd2
|
|
|
* [x] `_final_mass_of_merger` seems to be missing the tilt arguments...?
|
|
|
> Tilt angles are not required for PESummary because `spin_1z` and `spin_2z` are already precomputed and can be passed directly.
|
|
|
* [x] If those arguments to `_final_mass_of_merger` are changed, then probably in L1254f the param lists checking needs to be updated.
|
... | ... | |