| ... | ... | @@ -309,10 +309,16 @@ Maximum difference for af_evol_avg: 9.770286555355057e-07 |
|
|
|
## Review comments
|
|
|
|
|
|
|
|
* see in-line discussion threads on !245
|
|
|
|
* most other comments were resolved through the Mattermost chat. Some important topics/decisions:
|
|
|
|
* The last remaining differences against Nathan's reference implementation were traced down to only different redshift and q<->(m1,m2) treatments between PESummary and lalinferences.bayespputils, nothing to do with the NR fits or spin evolution.
|
|
|
|
* It was decided to only add a `_non_evolved` suffix if applicable, with evolved quantities being e.g. just `final_spin` without a suffic, to make life easier for external non-expert users of the released meta files.
|
|
|
|
* For the same reason, the evolved angles are not stored in the final output file.
|
|
|
|
* Reference frequency etc are stored in the metadata only, not repeated for each sample.
|
|
|
|
* The fits used are also added to the metadata, but the approximant used for spin evolution is not (as this cannot currently be changed by the user, so is uniquely reconstructable from the PESummary version number).
|
|
|
|
|
|
|
|
## sign-off
|
|
|
|
|
|
|
|
* pending 🚧
|
|
|
|
* pending on final resolution of open threads on !245, Nathan and David sign off 10th March 2020, with the reference output as here: https://ldas-jobs.ligo.caltech.edu/~charlie.hoy/projects/pesummary_review/remnant_fits/evolved_average_precessing/comparison_to_master/home.html
|
|
|
|
|
|
|
|
|
|
|
|
# surrogate fits
|
| ... | ... | |
